2D Truss Example

[dogukankaratas]

No description provided.

[OndraMichal]

• Missing default values. Need to fill all 13 of them each time it closes/crashes. Truss and diagonal layout should also be selected upon start. It crashes when Create Model is hit right after start of the dialogue. I think it would help a lot of users to see default values and their format and have it prepared also for rapid testing.
• Can't correct wrong value in cross-section (Lower Chord = IPE300). After warning msg the dialogue closes/crashes. This doesn't happen with material.
• If trere is any error in input data indicated, don't proceed with model creation. Stop there and allow user to correct it.
• Number of bays is in some cases incorrect when odd. This should be automatically corrected. The number of bays is set by buttons, so if the type of diagonal layout is set, the Number of bays should be set to even numbers (skipping odd ones).
• Number of bays is missing minimum value.
• To be honest, I would like to see pictures for 1,4, and 5th Truss layout short 2 bays to correspond to 2nd and 3rd picture or vice versa.
• Consider renaming button Done to Close.
• Consider lining up input fields for Number of bays, Total length etc.
• The 8th diagonal layout could have some description instead of empty picture. Like "No diagonals", "Empty" or something like that. Right now it looks little bit like missing picture.
• Truss layout=2, Number of bays=9,14, asymetrical length of edge parts.
• Truss layout=3, Number of bays=9,14, asymetrical length of edge parts.
• Truss layout=3 is missing start_modification and reset. It crashes.
• Truss layout=4, Number of bays=odd -> model not correct. Warning msg only with 3rd, 7th diagonal layout.
• Truss layout=5, Number of bays=odd -> model not correct. Warning msg only with 3rd, 7th diagonal layout.

Note:
It would be handy if we could terminate the connection to RFEM after every model is created. That way user knows the process is finished and can inspect it. I'll look into it again. Maybe I find something.

[pull-request-quantifier-deprecated]

This PR has 1458 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Large
Size       : +1452 -6
Percentile : 100%

Total files changed: 2

Change summary by file extension:
.py : +1452 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detetcted.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[OndraMichal]

all ok