refactor(test): replace replicated render logic with real function calls#89
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors functional rendering specs to stop duplicating production rendering logic and instead exercise the real internal render helpers exposed via each render module’s _test table.
Changes:
panel_render_spec.lua: replaces replicated grouped-folder-count counting/rendering with calls torender_folder_count()and validates rendered output.file_history_render_spec.lua: removes locally mirrored implementations ofrender_stat_bar/render_file_stats/ date formatting and calls the real_testhelpers/formatters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/diffview/tests/functional/panel_render_spec.lua | Updates folder-count tests to invoke render_folder_count() instead of reimplementing grouped counting/rendering logic. |
| lua/diffview/tests/functional/file_history_render_spec.lua | Switches file-history render tests to use render._test exports rather than duplicated local implementations/constants. |
Comments suppressed due to low confidence (1)
lua/diffview/tests/functional/panel_render_spec.lua:227
- Same issue here:
flat:find("1")/flat:find("2")is too weak and can produce false positives. Prefer checking the segments by the git-status highlight groups (DiffviewStatusAdded/DiffviewStatusDeleted) and/or asserting the exact count+icon strings, so the test fails if ordering or status grouping regresses.
local flat = comp:flat_text()
-- Should contain both status groups.
assert.truthy(flat:find("1"), "expected count for A status")
assert.truthy(flat:find("2"), "expected count for D status")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
58705f4 to
a04e47f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.