fix(api): persist selections to disk after set_revs so they survive restart#101
Merged
dlyongemallo merged 1 commit intomainfrom Apr 13, 2026
Merged
fix(api): persist selections to disk after set_revs so they survive restart#101dlyongemallo merged 1 commit intomainfrom
set_revs so they survive restart#101dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ensures DiffView file selections are persisted to disk under the new selection scope after DiffView:set_revs(), so selections survive a Neovim restart when the revision range changes.
Changes:
- Persist selections immediately after switching to the new selection scope key in
DiffView:set_revs(). - Add a functional test covering persistence under the new scope key after a rev change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/diffview/scene/views/diff/diff_view.lua | Saves selections under the updated scope key during set_revs() so persistence matches the new rev range. |
| lua/diffview/tests/functional/set_revs_spec.lua | Adds a regression test asserting selections are saved under the new scope key after set_revs(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
persist_selection_set_revs
branch
from
c9199c6 to
ccf1e76
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
persist_selection_set_revs
branch
from
ccf1e76 to
e528a4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #88.