fix: make diffopt save/restore state per-view#102
Merged
dlyongemallo merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes diffopt save/restore behavior so it’s tracked per View instance (instead of a single module-level saved value), preventing multiple open views from clobbering each other’s original diffopt state.
Changes:
- Store the pre-override
diffopton eachView(view._saved_diffopt) and restore from that per-view value. - Add a functional regression spec that simulates multiple views applying/restoring
diffoptindependently. - Export internal
apply/restorehelpers fromdiffview.scene.viewto support the regression spec.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/diffview/scene/view.lua | Moves saved diffopt state from a module-global to a per-view field; wires apply/restore to use self. |
| lua/diffview/tests/functional/view_spec.lua | Adds regression coverage for independent per-view diffopt saved state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The saved `diffopt` value was stored in a module-level variable, which could cause one view's close to clobber another view's saved state when multiple `Diffview` tabs are open. Move the saved value onto the view instance (`self._saved_diffopt`) so each view tracks its own snapshot.
dlyongemallo
force-pushed
the
diffopt_per_view
branch
from
a7d8f78 to
86c9c22
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.