test(panel): cover file_panel.list_options.path_style#110
Merged
dlyongemallo merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the functional test suite to cover the file_panel.list_options.path_style configuration, ensuring file-name rendering behaves correctly across "basename" and "full" modes, including when show_path is disabled (tree listing mode).
Changes:
- Added functional tests asserting the rendered highlight segments for
path_style = "basename"vs"full", including active-file highlighting behavior. - Verified
path_styleis ignored in tree mode (show_path = false). - Exposed
render_filevia thepanel_render._testtable so tests can exercise the real rendering logic with a lightweight panel stub.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/tests/functional/panel_render_spec.lua | Adds functional coverage for file_panel.list_options.path_style rendering behavior. |
| lua/diffview/scene/views/diff/render.lua | Exposes render_file through _test for direct use in tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.