fix(view): refresh tracked HEAD when right is STAGE#112
Merged
dlyongemallo merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes DiffView’s rev refresh behavior so that when the left side is tracking HEAD, it will refresh to the new HEAD even if the right side is STAGE (cached/staged view), preventing diffs from being computed against a stale base commit.
Changes:
- Update
DiffView.update_files()to refresh the trackedHEADrev wheneverself.left.track_headis set (no longer gated onrightbeingLOCAL). - Add a functional regression test that reproduces the stale-
HEADissue for cached/staged views and assertsleftupdates after a commit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/scene/views/diff/diff_view.lua | Refresh tracked HEAD regardless of right-side rev type, fixing staged/cached views keeping a stale left base. |
| lua/diffview/tests/functional/diff_view_spec.lua | Adds regression test ensuring left updates when HEAD moves while a right=STAGE view remains open. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.