fix(file): suppress FileType during synthetic BufReadPost#116
Merged
dlyongemallo merged 1 commit intomainfrom Apr 15, 2026
Merged
fix(file): suppress FileType during synthetic BufReadPost#116dlyongemallo merged 1 commit intomainfrom
FileType during synthetic BufReadPost#116dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a folding regression triggered by synthetic BufReadPost emission in File:attach_buffer() by preventing Neovim’s filetypedetect augroup from indirectly re-firing FileType, which can cause user FileType autocmds (e.g., treesitter folding setup) to override Diffview’s window-local options (ref #113).
Changes:
- Temporarily appends
FileTypetoeventignorewhile executing the syntheticBufReadPostautocmd for diff buffers. - Refactors the BufReadPost emission guard into a local
should_emit_buf_readboolean for readability. - Adds/updates functional tests to cover: skipping emission when
diffview_disable_tsis set, emitting only once across repeated attaches, suppressingFileType, and restoringeventignore.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/vcs/file.lua | Suppresses FileType during the synthetic BufReadPost to prevent folding/window-option clobbering. |
| lua/diffview/tests/functional/keymap_save_spec.lua | Adds regression and safety tests for BufReadPost emission behavior and eventignore restoration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.