revert(render): gate folder icons on use_icons#128
Merged
dlyongemallo merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
Reverts a07ce58 which led to behaviour which surprised users.
There was a problem hiding this comment.
Pull request overview
Adjusts Diffview’s file panel tree rendering so folder icons respect the use_icons option, aligning behavior with the option name and resolving the inconsistency reported in #125.
Changes:
- Gate folder icon rendering in the file tree on
conf.use_icons.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125.