Skip to content

test(render): assert folder icons honour use_icons#129

Merged
dlyongemallo merged 1 commit intomainfrom
fix_use_icons_folders
Apr 20, 2026
Merged

test(render): assert folder icons honour use_icons#129
dlyongemallo merged 1 commit intomainfrom
fix_use_icons_folders

Conversation

@dlyongemallo
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 20, 2026 08:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds functional coverage to ensure file panel folder icons render (or don’t) strictly based on the use_icons config flag, independent of icon plugin availability.

Changes:

  • Add a new describe block asserting folder icon behavior in tree listing mode.
  • Stub nvim-web-devicons during these tests to prevent hl.get_file_icon() from mutating use_icons when icon plugins aren’t installed.
  • Validate both expanded (folder_open) and collapsed (folder_closed) directory rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dlyongemallo dlyongemallo merged commit eaa5f2a into main Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants