Skip to content

style: enforce LuaJIT syntax, switch collapse_simple_statement to "Never"#133

Merged
dlyongemallo merged 1 commit intomainfrom
never_collapse_simple_statements
Apr 22, 2026
Merged

style: enforce LuaJIT syntax, switch collapse_simple_statement to "Never"#133
dlyongemallo merged 1 commit intomainfrom
never_collapse_simple_statements

Conversation

@dlyongemallo
Copy link
Copy Markdown
Owner

The stylua.toml is inconsistent with the code base as it hasn't been enforced. This brings it back into sync and enforces the style in the CI.

Copilot AI review requested due to automatic review settings April 22, 2026 06:35
@dlyongemallo dlyongemallo merged commit e3f4754 into main Apr 22, 2026
3 checks passed
@dlyongemallo dlyongemallo deleted the never_collapse_simple_statements branch April 22, 2026 06:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the repository’s Lua formatting with the intended StyLua configuration (including LuaJIT syntax) and adds CI enforcement so formatting drift is caught automatically.

Changes:

  • Update stylua.toml to use syntax = "LuaJIT" and set collapse_simple_statement = "Never".
  • Reformat Lua source + test files to match the updated StyLua rules.
  • Add a GitHub Actions lint job that runs stylua --check on lua/.

Reviewed changes

Copilot reviewed 123 out of 125 changed files in this pull request and generated no comments.

Show a summary per file
File Description
stylua.toml Updates StyLua formatting rules (LuaJIT syntax + statement collapsing).
.github/workflows/ci.yml Adds CI lint job to enforce StyLua formatting.
lua/diffview/vcs/utils.lua StyLua-driven reformatting.
lua/diffview/vcs/rev.lua StyLua-driven reformatting.
lua/diffview/vcs/log_entry.lua StyLua-driven reformatting.
lua/diffview/vcs/init.lua StyLua-driven reformatting.
lua/diffview/vcs/flag_option.lua StyLua-driven reformatting.
lua/diffview/vcs/file_dict.lua StyLua-driven reformatting.
lua/diffview/vcs/file.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/p4/rev.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/null/rev.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/null/init.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/jj/init.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/hg/rev.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/hg/commit.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/git/rev.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/git/parser.lua StyLua-driven reformatting.
lua/diffview/vcs/adapters/git/commit.lua StyLua-driven reformatting.
lua/diffview/vcs/adapter.lua StyLua-driven reformatting.
lua/diffview/ui/panels/help_panel.lua StyLua-driven reformatting.
lua/diffview/ui/panels/commit_log_panel.lua StyLua-driven reformatting.
lua/diffview/ui/panel.lua StyLua-driven reformatting.
lua/diffview/ui/models/file_tree/node.lua StyLua-driven reformatting.
lua/diffview/ui/model.lua StyLua-driven reformatting.
lua/diffview/tests/helpers.lua StyLua-driven reformatting.
lua/diffview/tests/functional/wrap_entries_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/window_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/view_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/utils_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/toggle_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/standard_view_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/set_revs_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/selections_api_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/selection_store_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/pathlib_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/null_adapter_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/node_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/nil_guards_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/misc_fixes_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/keymap_save_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/job_utils_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/inline_diff_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/hg_adapter_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/gitsigns_autocmd_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/git_parser_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/git_merge_matrix_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/fold_limit_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/focus_diff_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/file_history_render_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/file_entry_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/file_diff_view_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/event_emitter_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/diff_view_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/config_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/config_options_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/config_features_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/browser_and_restore_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/bootstrap_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/async_guards_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/actions_spec.lua StyLua-driven reformatting.
lua/diffview/tests/functional/actions_features_spec.lua StyLua-driven reformatting.
lua/diffview/stream.lua StyLua-driven reformatting.
lua/diffview/selection_store.lua StyLua-driven reformatting.
lua/diffview/scene/window.lua StyLua-driven reformatting.
lua/diffview/scene/views/standard/standard_view.lua StyLua-driven reformatting.
lua/diffview/scene/views/file_history/render.lua StyLua-driven reformatting.
lua/diffview/scene/views/file_history/option_panel.lua StyLua-driven reformatting.
lua/diffview/scene/views/file_history/file_history_view.lua StyLua-driven reformatting.
lua/diffview/scene/views/file_history/file_history_panel.lua StyLua-driven reformatting.
lua/diffview/scene/views/diff/render.lua StyLua-driven reformatting.
lua/diffview/scene/views/diff/listeners.lua StyLua-driven reformatting.
lua/diffview/scene/views/diff/file_panel.lua StyLua-driven reformatting.
lua/diffview/scene/views/diff/file_diff_view.lua StyLua-driven reformatting.
lua/diffview/scene/view.lua StyLua-driven reformatting.
lua/diffview/scene/layouts/diff_4.lua StyLua-driven reformatting.
lua/diffview/scene/layouts/diff_3.lua StyLua-driven reformatting.
lua/diffview/scene/layouts/diff_2.lua StyLua-driven reformatting.
lua/diffview/scene/layouts/diff_1_inline.lua StyLua-driven reformatting.
lua/diffview/scene/layouts/diff_1.lua StyLua-driven reformatting.
lua/diffview/scene/layout.lua StyLua-driven reformatting.
lua/diffview/scene/file_entry.lua StyLua-driven reformatting.
lua/diffview/perf.lua StyLua-driven reformatting.
lua/diffview/path.lua StyLua-driven reformatting.
lua/diffview/oop.lua StyLua-driven reformatting.
lua/diffview/multi_job.lua StyLua-driven reformatting.
lua/diffview/mock.lua StyLua-driven reformatting.
lua/diffview/logger.lua StyLua-driven reformatting.
lua/diffview/lib.lua StyLua-driven reformatting.
lua/diffview/lazy.lua StyLua-driven reformatting.
lua/diffview/job.lua StyLua-driven reformatting.
lua/diffview/init.lua StyLua-driven reformatting.
lua/diffview/hl.lua StyLua-driven reformatting.
lua/diffview/health.lua StyLua-driven reformatting.
lua/diffview/ffi.lua StyLua-driven reformatting.
lua/diffview/events.lua StyLua-driven reformatting.
lua/diffview/diff.lua StyLua-driven reformatting.
lua/diffview/debounce.lua StyLua-driven reformatting.
lua/diffview/control.lua StyLua-driven reformatting.
lua/diffview/config.lua StyLua-driven reformatting.
lua/diffview/async.lua StyLua-driven reformatting.
lua/diffview/arg_parser.lua StyLua-driven reformatting.
lua/diffview/api/views/diff/diff_view.lua StyLua-driven reformatting.
lua/diffview/api/selections.lua StyLua-driven reformatting.
lua/diffview/api/init.lua StyLua-driven reformatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants