ci: add DiffviewConfig schema drift check#141
Merged
dlyongemallo merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Introduces an automated CI guard to detect drift between lua/diffview/config.lua’s M.defaults keys and the top-level keys declared in @class DiffviewConfig / @class DiffviewConfig.user, helping keep config defaults and LuaLS type annotations synchronized.
Changes:
- Add
scripts/check_config_schema.luato mechanically compare top-level keys acrossM.defaults,DiffviewConfig, andDiffviewConfig.user. - Add
make check-config-schemaand a new CI job (config-schema) that runs the check in headless Neovim. - Expand StyLua checks/docs to include the
scripts/directory.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/check_config_schema.lua | Implements a source-based schema drift detector for config keys. |
| Makefile | Adds a check-config-schema target to run the drift check locally/CI. |
| CONTRIBUTING.md | Updates formatting instructions to include scripts/ and documents the new CI schema check. |
| .github/workflows/ci.yml | Extends the lint job to format-check scripts/ and adds a config-schema CI job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
schema_drift_check
branch
from
da1957f to
b1b6bd6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.