fix(job): drain stdio pipes before finalising on process exit#195
Merged
Conversation
The `uv.spawn` exit callback called `read_stop`/`try_close` on stdout and stderr the moment the child exited, dropping any chunks still queued behind the exit notification. Symptom: `DiffviewFileHistory` intermittently shows fewer commits than the range contains, because the tail of `git log`'s output never reaches `on_stdout`. Defer finalisation until both the process has exited and both pipes have delivered EOF.
There was a problem hiding this comment.
Pull request overview
This PR fixes an intermittent truncation of job output by ensuring uv.spawn jobs don’t finalize until both (1) the child process has exited and (2) stdout/stderr pipes have reached EOF, preventing late queued chunks from being dropped (notably impacting git log output used by file history views).
Changes:
- Update stdout/stderr reader callbacks to signal EOF via an
on_eofhook. - Defer job finalization logic until process-exit and both stdio EOF signals have been observed.
- Avoid closing stdout/stderr pipes from the process-exit callback to prevent dropping queued output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
uv.spawnexit callback calledread_stop/try_closeon stdout and stderr the moment the child exited, dropping any chunks still queued behind the exit notification. Symptom:DiffviewFileHistoryintermittently shows fewer commits than the range contains, because the tail ofgit log's output never reacheson_stdout.Defer finalisation until both the process has exited and both pipes have delivered EOF.