Skip to content

fix: misc. minor big fixes#20

Merged
dlyongemallo merged 1 commit intomainfrom
misc_fixes
Feb 26, 2026
Merged

fix: misc. minor big fixes#20
dlyongemallo merged 1 commit intomainfrom
misc_fixes

Conversation

@dlyongemallo
Copy link
Copy Markdown
Owner

  • Clear loading flags on error in update_files to prevent the file panel from getting stuck showing "Fetching changes...".
  • Fix misleading "clipboard" message for copy_hash (uses unnamed reg).
  • Fix Windows cmd /c start empty title arg for open_commit_in_browser.
  • Guard against empty resolved layout list in cycle_layout to prevent division-by-zero when config contains only unknown layout names.

* Clear loading flags on error in update_files to prevent the file
  panel from getting stuck showing "Fetching changes...".
* Fix misleading "clipboard" message for copy_hash (uses unnamed reg).
* Fix Windows cmd /c start empty title arg for open_commit_in_browser.
* Guard against empty resolved layout list in cycle_layout to prevent
  division-by-zero when config contains only unknown layout names.
Copilot AI review requested due to automatic review settings February 26, 2026 04:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses four distinct bug fixes in the diffview plugin:

Changes:

  • Fixed misleading message in copy_hash function (changed "clipboard" to "default register")
  • Fixed Windows cmd start command empty title argument
  • Added loading state cleanup on error to prevent stuck UI
  • Added guard against division-by-zero in cycle_layout when config contains only unknown layout names

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lua/diffview/scene/views/file_history/listeners.lua Fixed message accuracy for copy_hash (uses default register not clipboard) and corrected Windows start command syntax
lua/diffview/scene/views/diff/diff_view.lua Added loading state cleanup in error path to prevent file panel from getting stuck showing "Fetching changes..."
lua/diffview/actions.lua Refactored layout resolution to prevent division-by-zero when cycling layouts with empty resolved layout list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dlyongemallo dlyongemallo merged commit 1b778b6 into main Feb 26, 2026
6 checks passed
dlyongemallo added a commit that referenced this pull request Mar 31, 2026
dlyongemallo added a commit that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants