Merged
Conversation
Owner
dlyongemallo
commented
Feb 26, 2026
- Clear loading flags on error in update_files to prevent the file panel from getting stuck showing "Fetching changes...".
- Fix misleading "clipboard" message for copy_hash (uses unnamed reg).
- Fix Windows cmd /c start empty title arg for open_commit_in_browser.
- Guard against empty resolved layout list in cycle_layout to prevent division-by-zero when config contains only unknown layout names.
* Clear loading flags on error in update_files to prevent the file panel from getting stuck showing "Fetching changes...". * Fix misleading "clipboard" message for copy_hash (uses unnamed reg). * Fix Windows cmd /c start empty title arg for open_commit_in_browser. * Guard against empty resolved layout list in cycle_layout to prevent division-by-zero when config contains only unknown layout names.
There was a problem hiding this comment.
Pull request overview
This pull request addresses four distinct bug fixes in the diffview plugin:
Changes:
- Fixed misleading message in copy_hash function (changed "clipboard" to "default register")
- Fixed Windows cmd start command empty title argument
- Added loading state cleanup on error to prevent stuck UI
- Added guard against division-by-zero in cycle_layout when config contains only unknown layout names
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/scene/views/file_history/listeners.lua | Fixed message accuracy for copy_hash (uses default register not clipboard) and corrected Windows start command syntax |
| lua/diffview/scene/views/diff/diff_view.lua | Added loading state cleanup in error path to prevent file panel from getting stuck showing "Fetching changes..." |
| lua/diffview/actions.lua | Refactored layout resolution to prevent division-by-zero when cycling layouts with empty resolved layout list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
added a commit
that referenced
this pull request
Mar 31, 2026
dlyongemallo
added a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.