fix(async): harden async module and add tests#33
Merged
dlyongemallo merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR strengthens diffview.async’s core scheduling utilities and adds functional tests that exercise common guard patterns used to abort in-flight async work.
Changes:
- Add functional specs covering
control.Signalsemantics and a “closing signal” guard pattern. - Add functional specs validating
debounce.debounce_trailingbehavior under rapid calls. - Harden
async.timeoutandasync.schedulerby using explicit callback-parameter counts and handling timer allocation failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/diffview/tests/functional/async_guards_spec.lua | Adds functional coverage for Signal behavior, closing-guard abort patterns, and trailing debounce behavior. |
| lua/diffview/async.lua | Adjusts timeout/scheduler wrapping (explicit param count) and adds a fallback path when uv.new_timer() can’t be created. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c8676ca to
5d1bcb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.