refactor(git): improve parsing, caching, and test coverage#37
Merged
dlyongemallo merged 1 commit intomainfrom Mar 12, 2026
Merged
refactor(git): improve parsing, caching, and test coverage#37dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Improves Diffview’s Git parsing to better handle merge/combined diffs and tricky filenames, while extracting Git log/stat parsing into a dedicated parser module and adding functional coverage.
Changes:
- Extend diff patch parsing to recognize
diff --cc/diff --combinedheaders and combined hunk/header formats. - Refactor Git file-history stat parsing into
vcs/adapters/git/parser.lua, and add functional tests for both parsers. - Update Git adapter file listing/parsing to use NUL-delimited (
-z)git diffoutput and add a small cache for Cygwin path normalization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/diffview/vcs/utils.lua | Enhances diff header/hunk/index/path parsing for combined diffs. |
| lua/diffview/vcs/adapters/git/parser.lua | New module for structuring git log --raw/--numstat data and parsing namestat entries. |
| lua/diffview/vcs/adapters/git/init.lua | Uses new parser module, adds Cygwin path cache, switches tracked file parsing to -z output. |
| lua/diffview/tests/functional/git_parser_spec.lua | Adds functional tests for the new Git parser module. |
| lua/diffview/tests/functional/diff_parser_spec.lua | Adds functional tests for diff parsing, including combined diffs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9bfdfa8 to
65bdf3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.