fix(scene): cancel buffer creation for deactivated files#40
Merged
dlyongemallo merged 1 commit intomainfrom Mar 12, 2026
Merged
fix(scene): cancel buffer creation for deactivated files#40dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a performance/UX issue where buffer creation for diff files would continue even after the user navigated away, by checking the active flag at two points in create_buffer and short-circuiting early. The cancelled error is suppressed in the window's load_file to avoid confusing error messages.
Changes:
- Add early-exit checks in
File.create_bufferbefore and afterproduce_data(), cleaning up allocated buffers and raising a sentinelCANCELLEDerror - Change
File.activedefault fromfalsetotrue(previously never explicitly set totrue), and add an early bail-out inWindow.load_filefor inactive files - Add functional tests covering both cancellation scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/vcs/file.lua | Add CANCELLED sentinel, default active to true, add two cancellation checks in create_buffer |
| lua/diffview/scene/window.lua | Skip load_file for inactive files, suppress CANCELLED errors |
| lua/diffview/tests/functional/file_spec.lua | Tests for both pre- and mid-produce_data cancellation |
| lua/diffview/tests/functional/window_spec.lua | Tests for window-level bail-out and mid-async cancellation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0520575 to
c20ffc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.