fix(panel): restrict auto-sizing to file tree content only#43
Merged
dlyongemallo merged 1 commit intomainfrom Mar 16, 2026
Merged
fix(panel): restrict auto-sizing to file tree content only#43dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts Diffview panel auto-sizing so the computed width is driven by file-tree/log content rather than long header lines, and ensures headers are re-truncated after resizing.
Changes:
- Re-render after applying auto-width so header lines truncate to the final window width.
- Add
Panel:get_autosize_components()and updatecompute_content_width()to optionally measure only specified component line ranges. - Update Diff/FileHistory panels to restrict autosize measurement to their main content components, and add functional tests for the new behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/diffview/ui/panel.lua | Adds autosize component hook, restricts width measurement, and re-renders after auto-resize. |
| lua/diffview/tests/functional/panel_spec.lua | Adds tests for infer_width open/closed behavior and autosize-component measurement. |
| lua/diffview/scene/views/file_history/render.lua | Computes root path per-render so truncation reflects current panel width. |
| lua/diffview/scene/views/file_history/file_history_panel.lua | Restricts autosize measurement to log component. |
| lua/diffview/scene/views/diff/render.lua | Truncates revision pretty name while keeping hash prefix visible. |
| lua/diffview/scene/views/diff/file_panel.lua | Restricts autosize measurement to file list section components. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
669fc8a to
4c91a3b
Compare
4c91a3b to
edf7bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.