fix(view): skip redundant buffer re-open on update, fix window rebalance#49
Merged
dlyongemallo merged 1 commit intomainfrom Mar 20, 2026
Merged
fix(view): skip redundant buffer re-open on update, fix window rebalance#49dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts Diffview’s window management during panel resizing and reduces unnecessary buffer re-opening during file list updates, aiming to prevent disruptive layout changes and redundant reloading.
Changes:
- Switch panel resize equalization from
vertical wincmd =towincmd =to rebalance the whole tab layout when the auto-width panel changes. - Track the previously selected file during
update_files()and only callset_file()when initialization occurs, the selected entry identity changes, or the current layout’s loaded buffers were invalidated.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/ui/panel.lua | Adjusts the window rebalance command used after auto-width panel resizing. |
| lua/diffview/scene/views/diff/diff_view.lua | Skips redundant set_file() calls on file list refresh unless reopening is actually needed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.