refactor(utils): unify str_pad functions#52
Merged
dlyongemallo merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
dlyongemallo
force-pushed
the
unify_str_pad
branch
from
c9eab10 to
94c167e
Compare
dlyongemallo
changed the title
str_pad functions
There was a problem hiding this comment.
Pull request overview
Refactors diffview.utils string padding helpers by introducing a single str_pad() implementation and converting the existing left/right/center helpers into thin wrappers, with functional tests added to validate behavior.
Changes:
- Added
utils.str_pad(s, min_size, fill?, align?)to unify padding logic. - Updated
str_right_pad,str_left_pad, andstr_center_padto delegate tostr_pad. - Added functional tests covering
str_padand wrapper behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lua/diffview/utils.lua |
Introduces unified str_pad implementation and refactors existing pad helpers into wrappers. |
lua/diffview/tests/functional/utils_spec.lua |
Adds functional test coverage for str_pad and wrapper functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
unify_str_pad
branch
from
94c167e to
166a1a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.