refactor(actions): dedup goto_file variants#53
Merged
dlyongemallo merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors diffview.actions to deduplicate the goto_file* action implementations by routing them through a shared helper, and adds functional tests to validate the exported API and command routing behavior.
Changes:
- Introduce a local
open_goto_file(opts)helper inlua/diffview/actions.luaand reimplementgoto_file,goto_file_edit,goto_file_split, andgoto_file_tabvia that helper. - Add new functional specs covering the
goto_file*exports, expected error behavior without an active view, and command routing behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/diffview/actions.lua | Refactors goto_file* actions to share a single implementation helper. |
| lua/diffview/tests/functional/actions_spec.lua | Adds functional tests for goto_file* API surface and routing behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
dedup_goto_file
branch
from
6531ffa to
e17ee9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.