refactor(vcs): shared bootstrap preamble#54
Merged
dlyongemallo merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors VCS adapter bootstrapping to share a common “bootstrap preamble” in VCSAdapter, reducing duplicated executable-check/error-reporting logic across adapters.
Changes:
- Added
VCSAdapter.bootstrap_preamble()to standardize bootstrap initialization + executable validation and provide a shared error reporter. - Updated Git/Hg/Jj/P4 adapters to use the shared preamble.
- Added functional tests covering
bootstrap_preamble()behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/diffview/vcs/adapters/p4/init.lua | Uses shared bootstrap preamble before running p4 info connectivity check. |
| lua/diffview/vcs/adapters/jj/init.lua | Uses shared bootstrap preamble before version detection. |
| lua/diffview/vcs/adapters/hg/init.lua | Uses shared bootstrap preamble before version detection/parsing. |
| lua/diffview/vcs/adapters/git/init.lua | Uses shared bootstrap preamble before git version detection/semver check. |
| lua/diffview/vcs/adapter.lua | Introduces VCSAdapter.bootstrap_preamble() helper. |
| lua/diffview/tests/functional/bootstrap_spec.lua | Adds functional coverage for the new preamble helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
vcs_shared_bootstrap
branch
from
10c35d6 to
82e3007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.