refactor(config): pull out shared default keymaps#55
Merged
dlyongemallo merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors diffview.config’s default keymap definitions by extracting shared mappings into common tables and composing per-section keymap lists from those shared defaults. It also adds functional tests to ensure shared and section-specific mappings are present (and don’t leak across sections).
Changes:
- Added
common_nav_keymapsandcommon_panel_keymapsand used a composition helper to buildview,file_panel, andfile_history_paneldefaults. - Updated
viewdefaults to includeactions.compat.fold_cmdsvia composition rather thanunpack(). - Added functional tests validating shared/section-specific keymaps distribution across sections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/diffview/config.lua | Extracts shared default keymaps into common lists and composes section keymaps from them. |
| lua/diffview/tests/functional/config_spec.lua | Adds functional tests asserting shared keymaps exist in expected sections and section-only mappings don’t leak. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0627437 to
4349f2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.