Skip to content

refactor(view): panel cursor save/restore helpers#56

Merged
dlyongemallo merged 1 commit intomainfrom
panel_cursor_helpers
Mar 28, 2026
Merged

refactor(view): panel cursor save/restore helpers#56
dlyongemallo merged 1 commit intomainfrom
panel_cursor_helpers

Conversation

@dlyongemallo
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 24, 2026 11:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors duplicated “panel cursor save/restore” logic into StandardView helper methods, and updates view listeners to use the shared implementation. It also adds functional tests to validate the new helpers’ behavior.

Changes:

  • Add StandardView:save_panel_cursor() and StandardView:restore_panel_cursor() helper methods.
  • Replace duplicated cursor persistence logic in diff + file history listeners with calls to the new helpers.
  • Add functional tests covering save/restore behavior and no-op conditions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
lua/diffview/tests/functional/standard_view_spec.lua Adds functional coverage for the new panel cursor helpers.
lua/diffview/scene/views/standard/standard_view.lua Introduces shared save/restore helpers on StandardView.
lua/diffview/scene/views/file_history/listeners.lua Uses the new helpers on tab_enter/tab_leave instead of inline logic.
lua/diffview/scene/views/diff/listeners.lua Uses the new helpers on tab_enter/tab_leave instead of inline logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dlyongemallo dlyongemallo merged commit dbb5403 into main Mar 28, 2026
6 checks passed
@dlyongemallo dlyongemallo deleted the panel_cursor_helpers branch March 28, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants