refactor(view): panel cursor save/restore helpers#56
Merged
dlyongemallo merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors duplicated “panel cursor save/restore” logic into StandardView helper methods, and updates view listeners to use the shared implementation. It also adds functional tests to validate the new helpers’ behavior.
Changes:
- Add
StandardView:save_panel_cursor()andStandardView:restore_panel_cursor()helper methods. - Replace duplicated cursor persistence logic in diff + file history listeners with calls to the new helpers.
- Add functional tests covering save/restore behavior and no-op conditions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/tests/functional/standard_view_spec.lua | Adds functional coverage for the new panel cursor helpers. |
| lua/diffview/scene/views/standard/standard_view.lua | Introduces shared save/restore helpers on StandardView. |
| lua/diffview/scene/views/file_history/listeners.lua | Uses the new helpers on tab_enter/tab_leave instead of inline logic. |
| lua/diffview/scene/views/diff/listeners.lua | Uses the new helpers on tab_enter/tab_leave instead of inline logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.