refactor(job): pull out shared fail_cond and log_opt init#57
Merged
dlyongemallo merged 1 commit intomainfrom Mar 28, 2026
Merged
refactor(job): pull out shared fail_cond and log_opt init#57dlyongemallo merged 1 commit intomainfrom
fail_cond and log_opt init#57dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors job-related option initialization by centralizing fail_cond resolution and default log_opt construction into a shared utility module, and adds functional tests to validate the new helpers.
Changes:
- Introduces
diffview.job_utilswithresolve_fail_cond()anddefault_log_opt()helpers. - Updates
JobandMultiJobinitializers to use the shared helpers instead of duplicating logic. - Adds functional tests covering both helper functions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/job_utils.lua | New shared helper module for fail condition resolution and log option defaults. |
| lua/diffview/job.lua | Uses job_utils to initialize log_opt and check_status. |
| lua/diffview/multi_job.lua | Uses job_utils to initialize log_opt and check_status. |
| lua/diffview/tests/functional/job_utils_spec.lua | Adds functional test coverage for the new helper functions. |
Comments suppressed due to low confidence (1)
lua/diffview/multi_job.lua:10
local fmt = string.formatis now unused in this module after the refactor. Please remove it to avoid dead code.
local job_utils = require("diffview.job_utils")
local utils = lazy.require("diffview.utils") ---@module "diffview.utils"
local await = async.await
local fmt = string.format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.