fix(test): fix flaky tests on neovim nightly#60
Merged
dlyongemallo merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
Owner
Author
|
This race is apparently the cause of the failure in: https://github.com/dlyongemallo/diffview.nvim/actions/runs/23486180499/job/68342240312?pr=53 |
There was a problem hiding this comment.
Pull request overview
This PR updates PathLib.mkdir(..., { parents = true }) to tolerate an EEXIST error from uv.fs_mkdir() when multiple async callers race to create the same intermediate directory.
Changes:
- Wraps
uv.fs_mkdir()for each path component inmkdir -plogic to ignoreEEXIST. - Preserves existing error handling for other
uverrors viahandle_uv_err().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
fix_eexist_test_race
branch
from
40ba5b9 to
ca1c3db
Compare
dlyongemallo
changed the title
mkdir -p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.