fix(view): defensively use tabclose! to prevent E445 on close#67
Merged
dlyongemallo merged 1 commit intomainfrom Mar 30, 2026
Merged
fix(view): defensively use tabclose! to prevent E445 on close#67dlyongemallo merged 1 commit intomainfrom
tabclose! to prevent E445 on close#67dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes inability to close a Diffview tabpage when another window inside that tab contains a modified buffer (E445), as reported in #66.
Changes:
- Force tab closure in
View:close()by switching from:tabcloseto:tabclose!to avoid E445. - Add a functional regression test suite for
View:close()covering modified buffers, unmodified buffers, and “closing the last tabpage” behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lua/diffview/scene/view.lua |
Changes tab closing command to tabclose! to prevent E445 when modified buffers exist in other windows of the tabpage. |
lua/diffview/tests/functional/view_spec.lua |
Adds functional tests to reproduce the E445 scenario and validate View:close() behavior across key tabpage states. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
tabpage_close
branch
from
dad4e18 to
9a6799e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #66.