fix(file-panel): guard update_components against nil render_data#75
Merged
dlyongemallo merged 1 commit intomainfrom Mar 31, 2026
Merged
fix(file-panel): guard update_components against nil render_data#75dlyongemallo merged 1 commit intomainfrom
update_components against nil render_data#75dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Guards FilePanel:update_components() against being called before the panel buffer is initialized (e.g., when file_panel.show=false), and adds functional coverage for the “panel never opened” lifecycle to ensure these calls don’t error.
Changes:
- Add an early-return guard in
FilePanel:update_components()whenself.render_datais nil. - Add functional tests covering
FilePanelmethods when the panel has not been opened/initialized, plus toggling on/off behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/diffview/scene/views/diff/file_panel.lua | Adds a nil-guard so update_components() is safe when the panel hasn’t initialized its buffer/render state. |
| lua/diffview/tests/functional/panel_spec.lua | Adds functional tests for the show=false lifecycle to prevent regressions around uninitialized panel state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4c453a2 to
4da325f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74.
Relates to sindrets#303.