fix(file): detach LSP clients and disable auto-format on diffview:// buffers#79
Merged
dlyongemallo merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents Neovim LSP clients from remaining attached to diffview:// buffers and disables common auto-format hooks for those buffers, to avoid incorrect language features and unintended formatting on historical/staged content.
Changes:
- Add a buffer-local
LspAttachautocmd fordiffview://buffers that detaches any LSP client that attaches. - Set
vim.b[bufnr].autoformat = falsefordiffview://buffers to discourage formatter auto-runs. - Add functional tests asserting the
autoformatflag andLspAttachautocmd registration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lua/diffview/vcs/file.lua |
Adds LSP-detach guard and disables common autoformat behavior on diffview:// buffers during buffer creation. |
lua/diffview/tests/functional/file_spec.lua |
Adds functional tests verifying the new buffer guards are applied. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
fix_diffview_buffer_lsps_formatters
branch
from
9f7cd2d to
eecb75a
Compare
dlyongemallo
force-pushed
the
fix_diffview_buffer_lsps_formatters
branch
from
eecb75a to
8bec925
Compare
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72 and #73.