fix(file): use buftype=acwrite for stage-0 buffers to prevent LSP interference#81
Merged
dlyongemallo merged 1 commit intomainfrom Apr 6, 2026
Merged
fix(file): use buftype=acwrite for stage-0 buffers to prevent LSP interference#81dlyongemallo merged 1 commit intomainfrom
buftype=acwrite for stage-0 buffers to prevent LSP interference#81dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents Neovim’s built-in LspAttach inlay-hint logic from issuing textDocument/inlayHint requests using the unsupported diffview:// URI by disabling inlay hints on Diffview buffers before filetype detect can trigger LSP attachment.
Changes:
- Disable inlay hints on newly created
diffview://buffers immediately before running:filetype detect. - Add a functional test asserting inlay hints are disabled on
diffview://buffers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lua/diffview/vcs/file.lua |
Disables inlay hints prior to filetype detection to avoid inlay-hint requests for diffview:// URIs. |
lua/diffview/tests/functional/file_spec.lua |
Adds a functional test for inlay-hints-disabled behavior on diffview:// buffers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
fix_clangd_buffers
branch
from
c5cbd80 to
c716185
Compare
dlyongemallo
force-pushed
the
fix_clangd_buffers
branch
from
c716185 to
2e9365b
Compare
dlyongemallo
changed the title
diffview:// buffers before filetype detectionbuftype=acwrite for stage-0 buffers to prevent LSP interference
dlyongemallo
force-pushed
the
fix_clangd_buffers
branch
from
2e9365b to
f580682
Compare
|
Tested. 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #73.