fix(actions): handle empty diff in cycle_layout#84
Merged
dlyongemallo merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a runtime error in Diffview’s actions.cycle_layout() when invoked on a DiffView that has no current entry (e.g., an “empty diff” state), by returning early instead of iterating a nil file list.
Changes:
- Add an early return in
cycle_layout()when the computedfileslist is nil. - Add a TODO note about potentially supporting layout cycling even when the diff is empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
improve_diff_view_open
branch
from
808bfaa to
ef382a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82.