Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds functional test coverage for the diffview.api.CDiffView custom-view API, including regressions around pre-populated file lists and panel loading/render behavior.
Changes:
- Extend the CDiffView functional spec with coverage for API exports (
Rev,RevType) and construction defaults. - Add regression tests ensuring
is_loadingis cleared andinitializedis set after:open()when files are pre-populated (incl.file_panel.show = false). - Add
get_updated_files()coverage for both success and malformed return data fromupdate_files.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
force-pushed
the
add_cdiffview_test_coverage
branch
from
d9da730 to
48bea13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.