Skip to content

[VDO-6145] dm vdo: use GFP_NOIO for blkdev_issue_zeroout on format path#97

Merged
lorelei-sakai merged 1 commit into
dm-vdo:mainfrom
lorelei-sakai:fix/vdoformat-allocation-flags
Apr 28, 2026
Merged

[VDO-6145] dm vdo: use GFP_NOIO for blkdev_issue_zeroout on format path#97
lorelei-sakai merged 1 commit into
dm-vdo:mainfrom
lorelei-sakai:fix/vdoformat-allocation-flags

Conversation

@lorelei-sakai
Copy link
Copy Markdown
Member

GFP_NOWAIT is inappropriate when blkdev_issue_zeroout may sleep and bio_alloc can fail under pressure; use GFP_NOIO for clear_partition and vdo_clear_layout zeroout calls.

Copy link
Copy Markdown
Member

@bjohnsto bjohnsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

bjohnsto
bjohnsto previously approved these changes Apr 28, 2026
GFP_NOWAIT is inappropriate when blkdev_issue_zeroout may sleep and
bio_alloc can fail under pressure; use GFP_NOIO for clear_partition and
vdo_clear_layout zeroout calls.

Signed-off-by: Bruce Johnston <bjohnsto@redhat.com>
Signed-off-by: Matthew Sakai <msakai@redhat.com>
@lorelei-sakai lorelei-sakai merged commit 7de24ef into dm-vdo:main Apr 28, 2026
2 checks passed
@lorelei-sakai lorelei-sakai deleted the fix/vdoformat-allocation-flags branch April 28, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants