Conversation
Contributor
Reviewer's GuideReplaces the previous 'attack closest NPC' configuration with a more flexible NPC selection mode with multiple options, and updates the corresponding i18n keys consistently across all supported locale property files. Class diagram for updated NPC selection configurationclassDiagram
class GateConfig {
- boolean attackClosest
+ NpcSelectionMode npcSelectionMode
}
class NpcSelectionMode {
<<enumeration>>
DEFAULT
ALWAYS_CLOSEST
NPC_PRIORITY
}
GateConfig --> NpcSelectionMode
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The newly added
generic_gate.npc_selection_mode*strings are left in English across all non-English locale files; consider either adding translations or explicitly confirming that Crowdin will handle these so users don't see mixed-language UI. - Since
generic_gate.attack_closest*keys are removed, double-check that all code and configuration references have been migrated togeneric_gate.npc_selection_mode*to avoid missing-resource issues at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The newly added `generic_gate.npc_selection_mode*` strings are left in English across all non-English locale files; consider either adding translations or explicitly confirming that Crowdin will handle these so users don't see mixed-language UI.
- Since `generic_gate.attack_closest*` keys are removed, double-check that all code and configuration references have been migrated to `generic_gate.npc_selection_mode*` to avoid missing-resource issues at runtime.
## Individual Comments
### Comment 1
<location path="src/main/resources/com/deeme/lang/strings_pt.properties" line_range="355" />
<code_context>
-generic_gate.attack_closest.desc=It may work better than the other logic
+generic_gate.npc_selection_mode=NPC selection mode
+generic_gate.npc_selection_mode.list.default=Default
+generic_gate.npc_selection_mode.list.always_closest=Always the closest npc
+generic_gate.npc_selection_mode.list.npc_priority=NPC Priority
generic_gate.travel_to_next=Travel to the next map
</code_context>
<issue_to_address>
**suggestion (typo):** Use consistent capitalization for the NPC acronym in the new option label.
In other property entries this acronym appears as "NPC"; here it’s lowercase (`npc`). Please update this label to "Always the closest NPC" to match existing UI and locale usage.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
New Features: