Perf: cache dashboard HTML template at package init#136
Merged
Conversation
The dashboard template was parsed on every HTTP request via template.New().Funcs().Parse() — unnecessary CPU and allocation overhead. Move template parsing to a package-level variable initialized once at startup. DashboardHandler now reuses the pre-parsed template. Also simplified error handling: parse failure logs a warning at init time and returns an empty template (server still starts); execute failures log per-request as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard HTML template was parsed on every single HTTP request via
template.New().Funcs().Parse()— unnecessary CPU and allocation overhead.Move template parsing to a package-level variable initialized once at startup.
DashboardHandlernow reuses the pre-parsed template.Changes
dashboardTmplpackage-level variable with init-time parsingDashboardHandlercallsdashboardTmpl.Execute()directly — no per-request parsing[WARN]at init and returns an empty template (server still starts)if errblockVerified
go build✅go vet ./...✅go test -v ./stats/ -count 1✅ All passinggo test -race ./...✅ No races detected