Version 2.0#26
Merged
Merged
Conversation
Prismatik now includes a built-in calibration tool for all LEDs.
Slightly better than the "not declared in this scope" error.
This has the high potential to be misused by people attempting to ground the entire LED strip through an IO pin rather than set the reference level to an external supply. Doing the former will permanently damage the microcontroller. Instead of writing out a long comment explaining what to do, I'm just going to remove the (presumably seldom-used) feature.
This is redundant as 'adalight' is the only function called from the loop.
For PlatformIO compatibility. See #25.
One space between comment slashes and preprocessor defines, at least two spaces between definitions and explanatory comments.
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to do a small overhaul, removing some unused features and making some small improvements to performance and readability.
For starters the "calibrate" option was removed as it's no longer necessary - psieg's Prismatik now has global calibration available within the wizard.
The "ground pin" setting was removed for being confusing at best and destructive at worst. It was originally added to provide a convenient way to use an I/O pin as ground reference in case the other ground pins on the microcontroller were taken or inaccessible. But because this came with no documentation it was possible for someone to think that they could use it as the ground for the entire LED strip. The I/O pins have a low current limit and doing that would damage the port and possibly destroy the microcontroller. Rather than writing a detailed explanation of when to use it, I just decided to remove the feature altogether. It's trivial for the user to add the register writes back in if it's needed.
Some of the extra functions were removed for cleanliness and performance, like moving the
adalight()function contents into the main loop and rewriting the serial flush functionality as a macro. The extraneousstatickeywords from when I was chasing that memory bug were removed for all of the global variables, and I also cleaned up the comment formatting and added function prototypes for PlatformIO compatibility.Last but not least I made some tweaks to the README, such as correcting the website link and changing some formatting.
As this removes several features it's going to require a new major version: 2.0.