Drop get* variant functions, prefer parent, use ask.#1070
Merged
Conversation
These functions are no longer necessary because we put `ComponentId` in the `Reader` for `Effect` and the new `parent` function in #1047 will subsume `getParentComponentId` (and further it uses the `FFI.Internal` variant).
Owner
Author
|
This also fixes some issues with how the FFI module is haddocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are no longer necessary because we put
ComponentIdin theReaderforEffectand the newparentfunction in #1047 will subsumegetParentComponentId(and further it uses theFFI.Internalvariant).