Drop ComponentId usage in JS.#1372
Merged
Merged
Conversation
All `ComponentId` are managed in the Haskell heap, and exist in the closures of the callbacks. There is no need to transfer them during `mount()` / `unmount()` calls.
Removed componentId from Mount type definition.
dmjio
force-pushed
the
drop-component-id-destroy
branch
from
a6d81de to
b6ebac5
Compare
dmjio
force-pushed
the
drop-component-id-destroy
branch
from
74af5a3 to
9654edb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
ComponentIdare managed in the Haskell heap, and exist in the closures of the callbacks. There is no need to transfer them duringmount()/unmount()calls.