Skip to content

Update README related to post-link.mjs#980

Merged
dmjio merged 1 commit into
dmjio:masterfrom
rinn7e:rinn7e/add-note-post-link
Jun 11, 2025
Merged

Update README related to post-link.mjs#980
dmjio merged 1 commit into
dmjio:masterfrom
rinn7e:rinn7e/add-note-post-link

Conversation

@rinn7e
Copy link
Copy Markdown
Contributor

@rinn7e rinn7e commented Jun 11, 2025

Problem: Currently, post-link.mjs won't work properly, if the node version is not up-to-date.

Solution: Add a note about nodejs version in post-link.mjs section.

@dmjio dmjio self-requested a review June 11, 2025 07:04
Copy link
Copy Markdown
Owner

@dmjio dmjio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we make it a TIP so it pops out a bit at the user

> [!TIP]
> We recommend using an up-to-date `node` version (currently tested with `v24.2.0`) to ensure `post-link.mjs` works properly.

Problem: Currently, `post-link.mjs` won't work properly, if
the node version is not up-to-date.

Solution: Add a note about nodejs version in `post-link.mjs`
section.
Comment thread README.md

> [!TIP]
> We recommend using an up-to-date `node` version (currently tested with `v24.2.0`) to ensure `post-link.mjs` works properly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmjio I've pushed the fix according to your suggestion.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmjio dmjio merged commit 0c92eec into dmjio:master Jun 11, 2025
3 checks passed
dmjio pushed a commit that referenced this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants