Skip to content

[GraphBolt][CUDA] Ensure GPUCache has can store at least 1 item.#7544

Merged
mfbalin merged 1 commit intodmlc:masterfrom
mfbalin:gb_gpu_cache_capacity_assert
Jul 22, 2024
Merged

[GraphBolt][CUDA] Ensure GPUCache has can store at least 1 item.#7544
mfbalin merged 1 commit intodmlc:masterfrom
mfbalin:gb_gpu_cache_capacity_assert

Conversation

@mfbalin
Copy link
Copy Markdown
Collaborator

@mfbalin mfbalin commented Jul 20, 2024

Description

When it is constructed with 0, the code can crash unexpectedly. It is better to give a good error message instead.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs July 20, 2024 00:46
@dgl-bot
Copy link
Copy Markdown
Collaborator

dgl-bot commented Jul 20, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Copy Markdown
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: 00fa6ac

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit afcf65c into dmlc:master Jul 22, 2024
@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Jul 22, 2024
@mfbalin mfbalin deleted the gb_gpu_cache_capacity_assert branch July 22, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

expedited if it doesn't affect the main path approve first to unblock related projects, and review later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants