Upgrade TypeScript ESLint to 8.60.1 and add pnpm overrides#342
Conversation
|
Warning Review limit reached
More reviews will be available in 56 minutes and 20 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR upgrades the project's TypeScript-ESLint dependencies from version 8.59.4 to 8.60.1 and updates the ESLint configuration to use the TypeScript-ESLint recommended preset with an inline comment. All related packages are synchronized across devDependencies and pnpm.overrides. ChangesTypeScript-ESLint Configuration and Dependency Upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 67.04% 67.04%
=======================================
Files 67 67
Lines 789 789
Branches 175 169 -6
=======================================
Hits 529 529
Misses 260 260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7327612 to
c9d6e34
Compare
The config spread both eslint-config-next and our own typescript-eslint, each registering the @typescript-eslint plugin. As two separate installs they became distinct instances and ESLint flat config crashed with "Cannot redefine plugin" whenever the versions drifted apart (e.g. the 8.60 bump). Switch to the native Next.js setup: spread next/core-web-vitals + next/typescript (the latter already bundles the typescript-eslint recommended rules) and drop the direct @typescript-eslint/* and typescript-eslint dependencies. Now a single typescript-eslint instance (provided transitively by Next) is in play, so the crash cannot recur and no pnpm override is needed.
c9d6e34 to
b365ced
Compare
Summary
This PR updates the TypeScript ESLint tooling dependencies and adds pnpm package overrides to ensure consistent versions across the dependency tree.
Key Changes
@typescript-eslint/eslint-plugin,@typescript-eslint/parser, andtypescript-eslintfrom8.59.4to8.60.1pnpm.overridesconfiguration to enforce consistent versions of TypeScript ESLint packages across all transitive dependencieseslint.config.js("bringt Plugin + Rules mit" → "provides plugin + rules")Implementation Details
The pnpm overrides ensure that all dependencies in the tree use the same versions of the TypeScript ESLint packages, preventing version conflicts and ensuring consistent linting behavior across the project.
https://claude.ai/code/session_01AvthvYNhWdehGXzmQAUpLg
Summary by CodeRabbit