Open
Conversation
Add jsonc-parser dependency and readJsonc utility so that .bumpy/_config.json can contain // and /* */ comments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
The changes in this PR will be included in the next version bump.
|
theoephraim
force-pushed
the
feat/jsonc-config-support
branch
2 times, most recently
from
2fb8285 to
bd741b2
Compare
Add a lightweight JSONC parser (strips comments and trailing commas) so that .bumpy/_config.json can contain // and block comments. Adapted from https://github.com/fabiospampinato/tiny-jsonc Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
theoephraim
force-pushed
the
feat/jsonc-config-support
branch
from
bd741b2 to
1625ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//line comments,/* */block comments, and trailing commas from.bumpy/_config.jsonsrc/utils/jsonc.ts) with tests covering comments, trailing commas, string preservation, and invalid inputAdapted from tiny-jsonc.
Test plan
parseJsonchandles plain JSONparseJsoncstrips line and block commentsparseJsonchandles trailing commasparseJsoncpreserves comment-like content inside stringsparseJsoncthrows on invalid input🤖 Generated with Claude Code