Surface bump file parse errors to users#45
Merged
theoephraim merged 3 commits intomainfrom Apr 22, 2026
Merged
Conversation
Previously, invalid bump files (bad YAML, invalid bump types, etc.) were
silently skipped and the PR comment would just show "no bump files found".
Now parse errors are collected and surfaced in both CLI output and PR comments.
- parseBumpFile returns { bumpFile, errors } instead of BumpFile | null
- readBumpFiles returns { bumpFiles, errors } aggregating all parse errors
- CI check shows dedicated error comment with ❌ markers for broken files
- CI check shows distinct comment for intentionally empty bump files
- Parse errors always fail the check (even with --no-fail)
- version/release commands throw on parse errors
- Empty bump file only takes effect when no valid bump files exist alongside it
- filterBranchBumpFiles distinguishes broken files from intentionally empty ones
Collaborator
|
The changes in this PR will be included in the next version bump.
|
The regex required a newline between --- delimiters, so ---\n---\n (the intentionally empty format) didn't match and was reported as an error. Now empty frontmatter is detected early and returns no errors, matching the pre-existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan