fix: dynamic @required incorrectly resolved after type generation runs#371
Merged
theoephraim merged 1 commit intomainfrom Mar 11, 2026
Merged
fix: dynamic @required incorrectly resolved after type generation runs#371theoephraim merged 1 commit intomainfrom
theoephraim merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a1acf6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
When generateTypesIfNeeded() ran before resolveEnvValues() (as it does in the CLI), getTypeGenInfo() would call resolve() on dynamic decorators before their dependencies were resolved. This cached a stale result that corrupted the later processRequired() / processSensitive() calls during resolveEnvValues(). Fix: skip calling resolve() for any non-static (@required, @optional, @sensitive, @public) decorator in getTypeGenInfo(). Their runtime values are irrelevant for type generation — dynamic required items are always typed as optional, and dynamic sensitive decorators are not a documented pattern. Adds runTypeGeneration option to envFilesTest helper to reproduce this class of bug, and a failing test that now passes with the fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
theoephraim
force-pushed
the
fix/dynamic-required-type-gen-cache
branch
from
be4c6b6 to
a1acf6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateTypesIfNeeded()runs beforeresolveEnvValues()in the CLI, which causedgetTypeGenInfo()to callresolve()on dynamic decorators (e.g.@required=eq($OTHER, foo)) before their dependencies were resolvedprocessRequired()/processSensitive()later calledresolve()duringresolveEnvValues(), they got the wrong cached valueresolve()for any non-static@required,@optional,@sensitive, or@publicdecorator ingetTypeGenInfo()— their runtime values are irrelevant for type generation anyway (dynamic required → typed as optional; dynamic sensitive is not a supported pattern)@defaultRequired,@defaultSensitive) and string decorators (@icon,@docs) are always static so they're unaffectedTest plan
runTypeGeneration?: booleanoption toenvFilesTesthelper — when set, callsgetTypeGenInfo()on all items betweenfinishLoad()andresolveEnvValues(), mirroring the real CLI flowdynamic @required works (with type gen running first)) to userunTypeGeneration: true— fails before the fix, passes afterrequired-decorators.test.tspasstype-generation.test.tspass🤖 Generated with Claude Code