fix: escape special characters in --format shell output to prevent shell injection#472
Merged
theoephraim merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: c6c3d12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…otes Co-authored-by: philmillman <3722211+philmillman@users.noreply.github.com> Agent-Logs-Url: https://github.com/dmno-dev/varlock/sessions/ad8f47bc-0ff6-4213-92c5-f95bd235958f
Copilot
AI
changed the title
[WIP] Fix unescaped quotes in values for shell injection
fix: escape special characters in Mar 23, 2026
--format shell output to prevent shell injection
commit: |
philmillman
approved these changes
Mar 23, 2026
theoephraim
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
varlock load --format shellonly escaped"and\nin double-quoted output, leaving backticks,$VAR, and$()unescaped — causingeval "$(varlock load --format shell)"to fail or execute unintended commands when values contained those characters.Changes
'itself needs escaping via the'\''sequenceformatShellValue()as an exported helper to keep the escaping logic testable and isolated;envformat retains double-quote behavior unchanged$VAR,$(), double quotes, backslashes, single quotes, and newlinesBefore / After
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.