fix(1password): checkOpCliAuth() always returns a completion callback

[Copilot]

checkOpCliAuth() implements a mutex to serialize op CLI auth prompts. The first caller received opAuthDeferred.resolve; subsequent callers (including recursive retries in executeReadBatch) hit the if branch with no return, silently getting undefined. Call sites used authCompletedFn?.(true) to mask this — fine for the happy path, but in retry scenarios (partial batch failures: bad vault/item/field refs) the retried batch's completion was never properly signalled.

Changes

• checkOpCliAuth() return type is now always Promise<OpAuthCompletedFn> — first caller gets opAuthDeferred.resolve; subsequent callers get a typed no-op (_success) => undefined instead of falling off the end
• Added OpAuthCompletedFn type alias for the callback signature
• Typed createDeferredPromise<boolean>() explicitly

// Before: subsequent callers returned undefined (implicit)
if (opAuthDeferred) {
  await opAuthDeferred.promise;
  // ← no return
}

// After: always callable
if (opAuthDeferred) {
  await opAuthDeferred.promise;
  return (_success: boolean) => undefined; // no-op, but never undefined
}

[changeset-bot]

🦋 Changeset detected

Latest commit: ff5173a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@varlock/1password-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[theoephraim]

did not need a PR here. Just copilot being dumb.