fix: remove grammar-level regex literal parsing to fix path ambiguity#620
Merged
philmillman merged 4 commits intomainfrom Apr 15, 2026
Merged
fix: remove grammar-level regex literal parsing to fix path ambiguity#620philmillman merged 4 commits intomainfrom
philmillman merged 4 commits intomainfrom
Conversation
Paths like `/folder/foo/bar` were incorrectly parsed as regex literals. Moved regex detection from the PEG grammar to runtime consumers (remap() and matches type option) which check for regex-like unquoted strings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: fd4b0f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
varlock-website | 4820c56 | Commit Preview URL Branch Preview URL |
Apr 15 2026, 06:10 PM |
Remove regex literal detection from isDynamicValue() and update regex() deprecation text in intellisense catalog. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use quoted string patterns for URL matching tests instead of heavily-escaped unquoted regex syntax. Keep some unquoted /pattern/ tests for coverage of both styles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
philmillman
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegexLiteralrule from the PEG grammar andParsedEnvSpecRegexLiteralclass — paths like/folder/foo/barwere incorrectly parsed as regex patterns/pattern/flags) are now detected at runtime by specific consumers:remap()match values and thematchestype option onstring/urldata typesparseRegexLikeString()helper that detects unquoted strings matching/pattern/flagssyntaxTest plan
remap()are exact-matched, regex-like strings still work as patternsmatchesoption works with regex-like strings and quoted patterns🤖 Generated with Claude Code