RUN-157 UI Fragment Runic Draws#195
Merged
sergeykamilyevich merged 7 commits intomainfrom Dec 9, 2022
Merged
Conversation
Add upper banner
sergeykamilyevich
requested review from
Evgeniy7891,
RybinJD1,
Valeria297,
VaritskiArseniy,
dmowski and
sergey-mikhovich
get rid of unusable resources
Contributor
|
мне кажется или за текстом другой фон?
|
fix background picture crop
Collaborator
Author
|
исправил проблему с фоном |
Valeria297
approved these changes
Dec 8, 2022
RybinJD1
reviewed
Dec 9, 2022
|
|
||
| @Preview | ||
| @Composable | ||
| private fun UpperBanner(onClick: () -> Unit = {}) { |
Contributor
There was a problem hiding this comment.
думаю, компоуз функции лучше выносить из фрагментов в отдельные файлы.
RybinJD1
reviewed
Dec 9, 2022
| } | ||
| } | ||
|
|
||
| fun Modifier.rectShadow( |
Contributor
There was a problem hiding this comment.
это утильный метод? может лучше в отдельный файл в папку компонентов каких?
RybinJD1
approved these changes
Dec 9, 2022
sergeykamilyevich
deleted the
RUN-157_UI_Fragment_Runic_Draws_Add_upper_banner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add upper banner