[pull] main from MetaMask:main#171
Merged
Merged
Conversation
## Explanation Releases chain-agnostic-permission package changes
## Explanation This PR adds support for Sonic mainnet chainId in the list `SUPPORTED_CHAIN_IDS` so that tokenRatesController is able to fetch prices for tokens for this network. <img width="1122" alt="Screenshot 2025-04-24 at 23 18 08" src="https://github.com/user-attachments/assets/e294e948-6489-4c11-b121-6e1269886473" /> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Changelog <!-- THIS SECTION IS NO LONGER NEEDED. The process for updating changelogs has changed. Please consult the "Updating changelogs" section of the Contributing doc for more. --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
## Explanation The current implementation of `TokensController` relies heavily on a single selected network (`chainId`) as an instance property, which makes multi-chain token handling brittle and hard to scale. Additionally, some token operations unintentionally assume a persistent network context, introducing potential bugs when switching networks or performing actions concurrently across different chains. This PR refactors the `TokensController` to eliminate reliance on an internal `#chainId` property. Instead, all methods that require a network context now accept a `networkClientId` as an explicit parameter. This improves the controller’s ability to operate safely and predictably in a multi-chain environment. The `#onNetworkDidChange` logic and associated subscription were removed since network changes are now handled at the method level with explicit `networkClientId` parameters. All relevant internal state mutations and token metadata fetches are scoped to the appropriate chain via the `networkClientId -> chainId` mapping. This refactor is part of a broader initiative to support simultaneous multi-chain state handling across the codebase (see recent changes to `TokenRatesController` and `AccountTrackerController`). integration with UI: extension: MetaMask/metamask-extension#32274 <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References * Fixes #5580 <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Related to #67890 --> ## Changelog ### `@metamask/assets-controllers` - **UPDATE:** Refactor `TokensController` to support handling multiple chains in parallel. All network-dependent methods now require an explicit `networkClientId` parameter, enabling token operations to be fully scoped to a specific chain. This improves reliability and predictability when managing tokens across different networks. - **BREAKING:** Remove internal reliance on a single `chainId` instance property in `TokensController`. All chain-specific logic has been externalized. Consumers must now explicitly pass a `networkClientId` to methods that interact with the token state. This change may require updates on the client side to ensure correct chain context is provided during token actions. <!-- THIS SECTION IS NO LONGER NEEDED. The process for updating changelogs has changed. Please consult the "Updating changelogs" section of the Contributing doc for more. --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )