Don't wait for flushing when not necessary, and flush in getch#130
Closed
donno2048 wants to merge 1 commit intodmsc:masterfrom
Closed
Don't wait for flushing when not necessary, and flush in getch#130donno2048 wants to merge 1 commit intodmsc:masterfrom
getch#130donno2048 wants to merge 1 commit intodmsc:masterfrom
Conversation
Owner
|
Hi! If I'm reading this correctly, by setting queued_key to -1 at the start of getch the emulator will loose keys when the code calls kbhit(), checks that a key is waiting and then calls getch to process the key. IMHO, for this to work, the whole keyboard handling in emu2 should be rewritten to not depend on the emulated code calling keyboard functions to process the keyboard - and this is a major change. |
Contributor
Author
|
Will close if #135 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real hardware doesn't wait for flushing before pushing new values, also has the side effect of making #129 more reliable