fix: Improve binary detection#529
Merged
Merged
Conversation
closes #524 Originally we used to scan first 512 bytes which is not enough, here I am adding more files for initial extension triage, making it possible to unmark file as binary and making binary scanning more coherent which should support 99.9999999999% cases not breaking performance really hard
dmtrKovalenko
force-pushed
the
fix/file-detect
branch
from
9e9584a to
7d1410a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #524
Originally we used to scan first 512 bytes which is not enough, here I am adding more files for initial extension triage, making it possible to unmark file as binary and making binary scanning more coherent which should support 99.9999999999% cases not breaking performance really hard